linux-kernel - Re: [PATCH v2 5/5] fs: Add inode_assert_locked() and inode_assert_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHEg7oWG8CuyivWRsWLZZtw51oY0=PjLPRzFZDDZf=kzGg@mail.gmail.com>
Date:   Sun, 8 Oct 2023 22:26:40 +0200
From:   Mateusz Guzik <mjguzik@...il.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Chandan Babu R <chandan.babu@...cle.com>,
        "Darrick J . Wong" <djwong@...nel.org>, linux-xfs@...r.kernel.org
Subject: Re: [PATCH v2 5/5] fs: Add inode_assert_locked() and inode_assert_locked_excl()

On 10/7/23, Matthew Wilcox (Oracle) <willy@...radead.org> wrote:
> +static inline void inode_assert_locked_excl(const struct inode *inode)
> +{
> +	rwsem_assert_held_write(&inode->i_rwsem);
> +}
> +
>  static inline void inode_lock_nested(struct inode *inode, unsigned
> subclass)
>  {
>  	down_write_nested(&inode->i_rwsem, subclass);

Why "excl" instead of "write"? Apart from looking weird, it is
inconsistent with "prior art" in the file: i_mmap_assert_write_locked.

-- 
Mateusz Guzik <mjguzik gmail.com>