linux-kernel - Re: [PATCH] drm/msm/dpu: Use the encoder for default CRC source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <526457dd-37f2-467d-b583-b710a5e84b97@collabora.com>
Date:   Sun, 8 Oct 2023 20:21:07 -0300
From:   Helen Koike <helen.koike@...labora.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Rob Clark <robdclark@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, Rob Clark <robdclark@...omium.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Daniel Stone <daniels@...labora.com>,
        Vinod Polimera <quic_vpolimer@...cinc.com>,
        Kalyan Thota <quic_kalyant@...cinc.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dpu: Use the encoder for default CRC source



On 08/10/2023 16:59, Dmitry Baryshkov wrote:
> On Sun, 8 Oct 2023 at 20:56, Rob Clark <robdclark@...il.com> wrote:
>>
>> From: Rob Clark <robdclark@...omium.org>
>>
>> i-g-t expects the CRC to reflect any applied CTM.  But the layer mixer
>> source is upstream of the DSPP, so it is before the CTM is applied.
>>
>> Switch the default source to 'encoder' instead so that the CRC is
>> captured downstream of the DSPP.
>>
>> Signed-off-by: Rob Clark <robdclark@...omium.org>
>> ---
>>   drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt |  4 ----
>>   drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt |  5 -----
>>   drivers/gpu/drm/ci/xfails/msm-sdm845-fails.txt | 11 +----------
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c       |  6 +++---
> 
> I'm not sure, if updating the CI skip list together with the
> functional changs is a good idea, my preference would be towards two
> separate patches.

On the other hand, having both together in the same patch documents 
which tests this PATCH is fixing.

Regards,
Helen

> 
> Nevertheless:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 
>>   4 files changed, 4 insertions(+), 22 deletions(-)
> 
>