linux-kernel - Re: [PATCH 7/7] block, drivers: make lots of attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023100944-sandpit-bronco-3db4@gregkh>
Date:   Mon, 9 Oct 2023 19:30:12 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Max Kellermann <max.kellermann@...os.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Ilya Dryomov <idryomov@...il.com>,
        Dongsheng Yang <dongsheng.yang@...ystack.cn>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rodolfo Giometti <giometti@...eenne.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Mark Fasheh <mark@...heh.com>,
        Joel Becker <jlbec@...lplan.org>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        ceph-devel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-serial@...r.kernel.org, ocfs2-devel@...ts.linux.dev,
        linux-mm@...ck.org
Subject: Re: [PATCH 7/7] block, drivers: make lots of attribute_group globals
 const

On Mon, Oct 09, 2023 at 06:57:40PM +0200, Max Kellermann wrote:
> This moves those variables to the ".rodata" section which reduces the
> kernel size a bit and protects the variables by putting them on
> read-only pages at runtime.

The kernel size should still be the same overall, you are just moving
pointers from one section to another, right?

If not, what are the numbers, show them please.

But step back, are you SURE you can make these attribute group pointers
const?  They are modified by some subsystems by adding or removing items
from the lists, so why does the core need to change for that?

thanks,

greg k-h