[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e361e3c0-069c-4e91-8f3a-d7ab2de8bdd4@quicinc.com>
Date: Mon, 9 Oct 2023 23:57:44 +0530
From: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Maciej Żenczykowski <maze@...gle.com>,
onathan Corbet <corbet@....net>,
Linyu Yuan <quic_linyyuan@...cinc.com>,
<linux-usb@...r.kernel.org>, <linux-doc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <quic_ppratap@...cinc.com>,
<quic_wcheng@...cinc.com>, <quic_jackp@...cinc.com>
Subject: Re: [PATCH 2/2] usb: gadget: ncm: Add support to update
wMaxSegmentSize via configfs
On 10/9/2023 11:24 PM, Greg Kroah-Hartman wrote:
> On Mon, Oct 09, 2023 at 09:02:32PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/9/2023 8:38 PM, Greg Kroah-Hartman wrote:
>>> On Mon, Oct 09, 2023 at 07:50:05PM +0530, Krishna Kurapati wrote:
>>>> Currently the NCM driver restricts wMaxSegmentSize that indicates
>>>> the datagram size coming from network layer to 1514.
>>>
>>> I don't see that restriction in the existing driver, where does that
>>> happen?
>>
>> Hi Greg,
>>
>> In the ecm_desc, the following line restricts the value:
>>
>> .wMaxSegmentSize = cpu_to_le16(ETH_FRAME_LEN),
>
> Ok, so is that 1514? I don't know as I don't know what ETH_FRAM_LEN is.
>
Hi Greg,
Yes, that is 1514.
> So how about saying something to the affect of "the max segment size is
> currently limited to the ethernet frame length of the kernel which
> happens to be 1514 at this point in time."
>
Sure. I will rephrase this in v2 with the suggestion provided.
Regards,
Krishna,
Powered by blists - more mailing lists