linux-kernel - Re: [PATCH 02/10] scsi: libsas: Delete enum sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <900e549f-db0f-4c0a-9f67-b7f02294cd14@suse.de>
Date:   Mon, 9 Oct 2023 08:38:57 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.g.garry@...cle.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, chenxiang66@...ilicon.com,
        artur.paszkiewicz@...el.com, yanaijie@...wei.com,
        jinpu.wang@...ud.ionos.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        dlemoal@...nel.org
Subject: Re: [PATCH 02/10] scsi: libsas: Delete enum sas_class

On 8/14/23 16:10, John Garry wrote:
> enum sas_class prob would have been useful if function sas_show_class() was
> ever implemented, which it wasn't.
> 
> enum sas_class is used as asd_sas_port.class and asd_sas_phy.class, which
> are only ever set, so delete these members and the enum.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
>   drivers/scsi/aic94xx/aic94xx_hwi.c    | 1 -
>   drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
>   drivers/scsi/isci/phy.c               | 1 -
>   drivers/scsi/libsas/sas_internal.h    | 1 -
>   drivers/scsi/libsas/sas_port.c        | 2 --
>   drivers/scsi/mvsas/mv_init.c          | 1 -
>   drivers/scsi/pm8001/pm8001_init.c     | 1 -
>   include/scsi/libsas.h                 | 7 -------
>   8 files changed, 15 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman