[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4e785d2e-d310-4592-a75a-13549938dcef@linaro.org>
Date: Mon, 9 Oct 2023 10:36:13 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Matti Vaittinen <mazziesaccount@...il.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Paul Gazzillo <paul@...zz.com>,
Conor Dooley <conor+dt@...nel.org>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@...s.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: Avago APDS9306
On 08/10/2023 17:48, Subhajit Ghosh wrote:
> Add devicetree bindings for Avago APDS9306 Ambient Light Sensor.
>
> Signed-off-by: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
> ---
> .../bindings/iio/light/avago,apds9306.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml
> new file mode 100644
> index 000000000000..e8bb897782fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/avago,apds9306.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Avago APDS9306 Ambient Light Sensor
> +
> +maintainers:
> + - Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
> +
> +description:
> + Datasheet at https://docs.broadcom.com/doc/AV02-4755EN
This is exactly the same as two other Avago devices. It should be
squashed - first two device schemas squashed, then add new device support.
Also, the supply is not vin, but vdd.
Best regards,
Krzysztof
Powered by blists - more mailing lists