linux-kernel - Re: [Patch] cpufreq: tegra194: remove redundant AND with cpu_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231009084133.tvtqjhr4qac3tosm@vireshk-i7>
Date:   Mon, 9 Oct 2023 14:11:33 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Sumit Gupta <sumitg@...dia.com>
Cc:     rafael@...nel.org, linux-pm@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        treding@...dia.com, jonathanh@...dia.com, bbasu@...dia.com
Subject: Re: [Patch] cpufreq: tegra194: remove redundant AND with
 cpu_online_mask

On 09-10-23, 13:54, Sumit Gupta wrote:
> Remove redundant 'AND' with cpu_online_mask as the policy->cpus always
> contains only the currently online CPUs.
> 
> Suggested-by: Viresh Kumar <viresh.kumar@...aro.org>
> Link: https://lore.kernel.org/lkml/20231003050019.a6mcchw2o2z2wkrh@vireshk-i7/
> Signed-off-by: Sumit Gupta <sumitg@...dia.com>
> ---
>  drivers/cpufreq/tegra194-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 386aed3637b4..607e699b3d84 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -135,7 +135,7 @@ static void tegra234_set_cpu_ndiv(struct cpufreq_policy *policy, u64 ndiv)
>  	u32 cpu, cpuid, clusterid;
>  	u64 mpidr_id;
>  
> -	for_each_cpu_and(cpu, policy->cpus, cpu_online_mask) {
> +	for_each_cpu(cpu, policy->cpus) {
>  		data->soc->ops->get_cpu_cluster_id(cpu, &cpuid, &clusterid);
>  
>  		/* use physical id to get address of per core frequency register */

Applied. Thanks.

-- 
viresh