linux-kernel - RE: [PATCH 2/2] tools/virtio: Add hints when module is not installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Oct 2023 02:44:55 +0000
From:   Liming Wu <liming.wu@...uarmicro.com>
To:     Jason Wang <jasowang@...hat.com>
CC:     "Michael S . Tsirkin" <mst@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "398776277@...com" <398776277@...com>
Subject: RE: [PATCH 2/2] tools/virtio: Add hints when module is not installed



> -----Original Message-----
> From: Jason Wang <jasowang@...hat.com>
> Sent: Sunday, October 8, 2023 12:36 PM
> To: Liming Wu <liming.wu@...uarmicro.com>
> Cc: Michael S . Tsirkin <mst@...hat.com>; kvm@...r.kernel.org;
> virtualization@...ts.linux-foundation.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; 398776277@...com
> Subject: Re: [PATCH 2/2] tools/virtio: Add hints when module is not installed
> 
> On Tue, Sep 26, 2023 at 1:00 PM <liming.wu@...uarmicro.com> wrote:
> >
> > From: Liming Wu <liming.wu@...uarmicro.com>
> >
> > Need to insmod vhost_test.ko before run virtio_test.
> > Give some hints to users.
> >
> > Signed-off-by: Liming Wu <liming.wu@...uarmicro.com>
> > ---
> >  tools/virtio/virtio_test.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> > index 028f54e6854a..ce2c4d93d735 100644
> > --- a/tools/virtio/virtio_test.c
> > +++ b/tools/virtio/virtio_test.c
> > @@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev,
> unsigned long long features)
> >         dev->buf = malloc(dev->buf_size);
> >         assert(dev->buf);
> >         dev->control = open("/dev/vhost-test", O_RDWR);
> > +
> > +       if (dev->control < 0)
> > +               fprintf(stderr, "Install vhost_test module" \
> > +               "(./vhost_test/vhost_test.ko) firstly\n");
> 
> There should be many other reasons to fail for open().
> 
> Let's use strerror()?
Yes,  Thanks for the review. 
Please rechecked the code as follow:
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -135,6 +135,11 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
        dev->buf = malloc(dev->buf_size);
        assert(dev->buf);
        dev->control = open("/dev/vhost-test", O_RDWR);
+
+       if (dev->control == NULL)
+               fprintf(stderr,
+                       "%s: Check whether vhost_test.ko is installed.\n",
+                       strerror(errno));
        assert(dev->control >= 0);
        r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
        assert(r >= 0);
 
Thanks