linux-kernel - Re: [PATCH linux-next 1/3] sched/psi: Change update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSP2nMGZhtA8hr23@gmail.com>
Date:   Mon, 9 Oct 2023 14:48:28 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     yang.yang29@....com.cn
Cc:     surenb@...gle.com, peterz@...radead.org, hannes@...xchg.org,
        mingo@...hat.com, linux-kernel@...r.kernel.org,
        juri.lelli@...hat.com
Subject: Re: [PATCH linux-next 1/3] sched/psi: Change update_triggers() to a
 void function


* yang.yang29@....com.cn <yang.yang29@....com.cn> wrote:

> From: Yang Yang <yang.yang29@....com.cn>
> 
> Update_triggers() always return now + group->rtpoll_min_period, and the
> return value is only used by psi_rtpoll_work(), so change update_triggers()
> to a void function, let group->rtpoll_next_update = now +
> group->rtpoll_min_period directly.
> This will avoid unnecessary function return value passing.
> 
> Signed-off-by: Yang Yang <yang.yang29@....com.cn>
> Suggested-by: Suren Baghdasaryan <surenb@...gle.com>
> Suggested-by: Ingo Molnar <mingo@...nel.org>

Thanks for the split-up!

I'll remove the Suggested-by tags you added for me: I didn't suggest the
changes themselves, only the split-up, which isn't credit-worthy :-)

Thanks,

	Ingo