linux-kernel - Re: [PATCH RESEND] xhci: Keep interrupt disabled in initialization until host is running.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023100943-underhand-wizard-6901@gregkh>
Date:   Mon, 9 Oct 2023 14:52:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Prashanth K <quic_prashk@...cinc.com>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hongyu Xie <xy521521@...il.com>,
        Mathias Nyman <mathias.nyman@...el.com>, stable@...nel.org,
        Hongyu Xie <xiehongyu1@...inos.cn>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH RESEND] xhci: Keep interrupt disabled in initialization
 until host is running.

On Mon, Oct 09, 2023 at 04:09:26PM +0530, Prashanth K wrote:
> From: Hongyu Xie <xy521521@...il.com>
> 
> [ Upstream commit a808925075fb750804a60ff0710614466c396db4 ]
> 
> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> It's possible that you will receive thousands of interrupt requests
> after initialization for 2.0 roothub. And you will get a lot of
> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> disabled?". This amount of interrupt requests will cause the entire
> system to freeze.
> This problem was first found on a device with ASM2142 host controller
> on it.
> 
> [tidy up old code while moving it, reword header -Mathias]
> 
> Cc: stable@...nel.org
> Signed-off-by: Hongyu Xie <xiehongyu1@...inos.cn>
> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@linux.intel.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: <stable@...r.kernel.org> # 5.15
> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> ---

Any specific reason you missed adding the extra blank line in this
version of the backport that the original added?  That is going to cause
problems in the future if other patches are added on top of this that
would be expecting it because it is that way in Linus's tree.

And why is this only relevant for 5.15.y?

thanks,

greg k-h