linux-kernel - Re: [PATCH] net: appletalk: remove cops support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <cace6f63-42a2-4848-9880-c48fb2b31fdf@app.fastmail.com>
Date:   Mon, 09 Oct 2023 16:08:59 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Jakub Kicinski" <kuba@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
        linux-spdx@...r.kernel.org, "Prarit Bhargava" <prarit@...hat.com>,
        "Christoph Hellwig" <hch@...radead.org>,
        "Vitaly Kuznetsov" <vkuznets@...hat.com>, jschlst@...ba.org,
        "Doug Brown" <doug@...morgal.com>
Subject: Re: [PATCH] net: appletalk: remove cops support

On Wed, Oct 4, 2023, at 20:52, Jakub Kicinski wrote:
> On Wed, 27 Sep 2023 11:00:30 +0200 Greg Kroah-Hartman wrote:
>> The COPS Appletalk support is very old, never said to actually work
>> properly, and the firmware code for the devices are under a very suspect
>> license.  Remove it all to clear up the license issue, if it is still
>> needed and actually used by anyone, we can add it back later once the
>> license is cleared up.
>
> Nice, Doug and Arnd also mentioned this in the past so let me add
> them to the CC as I apply this...

Yes, definitely, thanks Greg for getting this done. I think every
time this came up we concluded that it can be removed, we just never
finished the job.

Acked-by: Arnd Bergmann <arnd@...db.de>
Link: https://lore.kernel.org/netdev/e490dd0c-a65d-4acf-89c6-c06cb48ec880@app.fastmail.com/
Link: https://lore.kernel.org/netdev/9cac4fbd-9557-b0b8-54fa-93f0290a6fb8@schmorgal.com/

Semi-related:

Since this removes one of the two callers of the .ndo_do_ioctl()
callback, I've had a new look at that bit as well and ended up
with a refresh of the missing bits of [1], which I'll submit next.

     Arnd

[1] https://lore.kernel.org/lkml/20201106221743.3271965-1-arnd@kernel.org/