linux-kernel - Re: [PATCH 2/3] delayacct: convert task->delays to a object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231009141841.GF14330@noisy.programming.kicks-ass.net>
Date:   Mon, 9 Oct 2023 16:18:41 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     brookxu <brookxu.cn@...il.com>
Cc:     bsingharora@...il.com, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] delayacct: convert task->delays to a object

On Mon, Oct 09, 2023 at 07:38:58PM +0800, brookxu wrote:

> I found another question when I tried to allocate task_delay_info on demand,
> it is hard for us to
> 
> determine whether tsk->delays is NULL due to memory failure or delayacct
> disabled, if due to
> 
> memory failure I think we should not try to allocate it again, otherwise we
> may have performance
> 
> issues, such as following code. If we limit only try once, the code is very
> trick..

Yeah, I wouldn't worry about that. Not until it's shown to be a real
issue. First do the simple thing, only make it more complicated if
there's a real need.