linux-kernel - Re: [PATCH 1/4] time: add ktime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o7h7q2av.ffs@tglx>
Date:   Mon, 09 Oct 2023 16:48:56 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Richard Cochran <richardcochran@...il.com>,
        John Stultz <jstultz@...gle.com>
Cc:     Mahesh Bandewar         (महेश बंडेवा <maheshb@...gle.com>,
        Netdev <netdev@...r.kernel.org>,
        Linux <linux-kernel@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Don Hatchett <hatch@...gle.com>,
        Yuliang Li <yuliangli@...gle.com>,
        Mahesh Bandewar <mahesh@...dewar.net>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH 1/4] time: add ktime_get_cycles64() api

On Sat, Sep 30 2023 at 14:15, Richard Cochran wrote:
> On Fri, Sep 29, 2023 at 12:06:46AM -0700, John Stultz wrote:
>> But I still think we should avoid exporting the raw cycle values
>> unless there is some extremely strong argument for it
>
> Looks like the argument was based on a misunderstanding of what
> CLOCK_MONOTONIC_RAW actually is.  So, please, let's not expose the raw
> cycle counter value.

Correct. Exposing the raw counter value is broken if the counter wraps
around on a regular base.

Thanks,

        tglx