linux-kernel - Re: [PATCH] perf hisi-ptt: Fix memory leak in lseek failure handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjx04RFjE6x+09mh7SjVWRiB46czYGWenVzf=LaKCrqSA@mail.gmail.com>
Date:   Sun, 8 Oct 2023 22:21:49 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Kuan-Wei Chiu <visitorckw@...il.com>
Cc:     yangyicong@...ilicon.com, jonathan.cameron@...wei.com,
        peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf hisi-ptt: Fix memory leak in lseek failure handling

On Mon, Oct 2, 2023 at 9:48 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> Hello,
>
> On Sat, Sep 30, 2023 at 12:27 AM Kuan-Wei Chiu <visitorckw@...il.com> wrote:
> >
> > In the previous code, there was a memory leak issue where the previously
> > allocated memory was not freed upon a failed lseek operation. This patch
> > addresses the problem by releasing the old memory before returning -errno
> > in case of a lseek failure. This ensures that memory is properly managed
> > and avoids potential memory leaks.
> >
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
>
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Applied to perf-tools-next, thanks!