[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <68c4b7ee-345f-42e4-a69e-700384b711ad@kernel.org>
Date: Mon, 9 Oct 2023 07:28:03 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-serial@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tty: vc_screen: make vc_class constant
On 05. 10. 23, 15:33, Greg Kroah-Hartman wrote:
> Now that the driver core allows for struct class to be in read-only
> memory, making all 'class' structures to be declared at build time
> placing them into read-only memory, instead of having to be dynamically
> allocated at load time.
>
> Cc: Jiri Slaby <jirislaby@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> drivers/tty/vt/vc_screen.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/tty/vt/vc_screen.c b/drivers/tty/vt/vc_screen.c
> index 829c4be66f3b..b16ea517bb17 100644
> --- a/drivers/tty/vt/vc_screen.c
> +++ b/drivers/tty/vt/vc_screen.c
...
> @@ -811,11 +810,12 @@ int __init vcs_init(void)
>
> if (register_chrdev(VCS_MAJOR, "vcs", &vcs_fops))
> panic("unable to get major %d for vcs device", VCS_MAJOR);
> - vc_class = class_create("vc");
> + if (class_register(&vc_class))
> + panic("unable to create vc_class");
FWIW it's no longer "create". Now it's "register".
Anyway, for the sake of archives:
Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
regards,
--
js
suse labs
Powered by blists - more mailing lists