linux-kernel - Re: [PATCH v3 0/2] x86/sev: Generalize sev_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34c937ad-f8d8-4f03-9f0d-bf46398b31df@amd.com>
Date:   Tue, 10 Oct 2023 15:46:37 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v3 0/2] x86/sev: Generalize sev_setup_arch()

On 10/10/23 09:52, Alexander Shishkin wrote:
> Hi,
> 
> v3:
>   * rebased
>   * moved mem_encrypt_setup_arch under a common #ifdef CONFIG_X86_MEM_ENCRYPT
>     per Tom's comment
> 
> v2: [1]
>   * added 2/2, which is a minor cleanup
> 
> v1: [0]
> 
> The main intention of this is to move sev_setup_arch() to mem_encrypt.c
> to reflect the fact that it's not SEV-specific, but covers TDX as well,
> although unintentionally.
> 
> While looking at it, I also noticed that mem_encrypt_amd.c still
> includes virtio_config.h, which was needed for the code that since got
> moved to a different place (and even there doesn't require the include
> any more).
> 
> [0] https://lore.kernel.org/all/20230530121728.28854-1-alexander.shishkin@linux.intel.com/
> [1] https://lore.kernel.org/all/20230609171214.31846-1-alexander.shishkin@linux.intel.com/
> 
> Alexander Shishkin (2):
>    x86/sev: Move sev_setup_arch() to mem_encrypt.c
>    x86/sev: Drop unneeded include
> 
>   arch/x86/include/asm/mem_encrypt.h |  4 ++--
>   arch/x86/kernel/setup.c            |  2 +-
>   arch/x86/mm/mem_encrypt.c          | 34 ++++++++++++++++++++++++++++
>   arch/x86/mm/mem_encrypt_amd.c      | 36 ------------------------------
>   4 files changed, 37 insertions(+), 39 deletions(-)
> 

For the series:

Reviewed-by: Tom Lendacky <thomas.lendacky@....com>