linux-kernel - Re: [Linux-stm32] [PATCH] media: stm32-dcmi: Drop unnecessary of_match_device() call

Open Source and information security mailing list archives

Message-ID: <20231010075907.GA1642294@gnbcxd0016.gnb.st.com>
Date:   Tue, 10 Oct 2023 09:59:07 +0200
From:   Alain Volmat <alain.volmat@...s.st.com>
To:     Rob Herring <robh@...nel.org>
CC:     Hugues Fruchet <hugues.fruchet@...s.st.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>
Subject: Re: [Linux-stm32] [PATCH] media: stm32-dcmi: Drop unnecessary
 of_match_device() call

Hi Rob,

thanks for the patch.

Acked-by: Alain Volmat <alain.volmat@...s.st.com>

Regards,
Alain

On Mon, Oct 09, 2023 at 04:13:32PM -0500, Rob Herring wrote:
> If probe is reached, we've already matched the device and in the case of
> DT matching, the struct device_node pointer will be set. Therefore, there
> is no need to call of_match_device() in probe.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/media/platform/st/stm32/stm32-dcmi.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 8cb4fdcae137..48140fdf40bb 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -20,7 +20,6 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/of_graph.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
> @@ -1890,7 +1889,6 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi)
>  static int dcmi_probe(struct platform_device *pdev)
>  {
>  	struct device_node *np = pdev->dev.of_node;
> -	const struct of_device_id *match = NULL;
>  	struct v4l2_fwnode_endpoint ep = { .bus_type = 0 };
>  	struct stm32_dcmi *dcmi;
>  	struct vb2_queue *q;
> @@ -1899,12 +1897,6 @@ static int dcmi_probe(struct platform_device *pdev)
>  	struct clk *mclk;
>  	int ret = 0;
>  
> -	match = of_match_device(of_match_ptr(stm32_dcmi_of_match), &pdev->dev);
> -	if (!match) {
> -		dev_err(&pdev->dev, "Could not find a match in devicetree\n");
> -		return -ENODEV;
> -	}
> -
>  	dcmi = devm_kzalloc(&pdev->dev, sizeof(struct stm32_dcmi), GFP_KERNEL);
>  	if (!dcmi)
>  		return -ENOMEM;
> -- 
> 2.42.0
> 
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@...md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives