linux-kernel - Re: [PATCH v6 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f30ee046-82b2-ad7e-f173-1ac9e8b29370@intel.com>
Date:   Tue, 10 Oct 2023 13:53:28 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        <alsa-devel@...a-project.org>
CC:     Maarten Lankhorst <dev@...khorst.se>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        "Daniel Baluta" <daniel.baluta@....com>,
        <linux-kernel@...r.kernel.org>,
        <sound-open-firmware@...a-project.org>,
        Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
Subject: Re: [PATCH v6 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to
 before probe_work.

On 2023-10-10 1:43 PM, Cezary Rojewski wrote:
> On 2023-10-04 4:55 PM, Maarten Lankhorst wrote:

...

>> @@ -465,10 +461,19 @@ static int avs_pci_probe(struct pci_dev *pci, 
>> const struct pci_device_id *id)
>>       pci_set_drvdata(pci, bus);
>>       device_disable_async_suspend(dev);
>> +    ret = snd_hdac_i915_init(bus, false);
>> +    if (ret == -EPROBE_DEFER)
>> +        goto err_i915_init;
>> +    else if (ret < 0)
> 
> The 'else' part seems redundant. s/else if/else/.

Spelling error on my part. What I meant is s/else if/if/.

>> +        dev_info(bus->dev, "i915 init unsuccessful: %d\n", ret);
>> +