linux-kernel - Re: [PATCH 1/1] gpio: tegra186: Set fwnode of the GPIO chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSVN73ffDkGBzmmI@smile.fi.intel.com>
Date:   Tue, 10 Oct 2023 16:13:19 +0300
From:   Andy Shevchenko <andy@...nel.org>
To:     Dipen Patel <dipenp@...dia.com>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-gpio@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] gpio: tegra186: Set fwnode of the GPIO chip

On Mon, Oct 09, 2023 at 10:38:58AM -0700, Dipen Patel wrote:

Tbank you! My comments below.

> Any driver that depends on the GPIO match function to locate the GPIO
> controller, it has to use the fwnode from the gpio_chip structure. But
> with [1], it is GPIO providers job to set any members of the gpio_chip
> structure. This patch addresses that.

> [1] https://git.kernel.org/pub/scm/linux/kernel/git/pateldipen1984/linux.git/patch/drivers/gpio/gpiolib.c?id=daecca4b8433d47f0db4933bcc0f283d530ba22e

Use Link: tag for this?

...

> +	/*
> +	 * This is needed for driver using gpio device matching where it
> +	 * has to use gpio_chip fwnode to match the gpio controller.
> +	 */
> +	gpio->gpio.fwnode = of_node_to_fwnode(pdev->dev.of_node);

of_node_to_fwnode() is specific to IRQ, in other places we use generic
of_fwnode_handle(). That's why better just to use dev_fwnode().

...

With the above addressed:
Reviewed-by: Andy Shevchenko <andy@...nel.org>

-- 
With Best Regards,
Andy Shevchenko