linux-kernel - Re: [PATCH] of: rexport of_find_next_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2023 16:05:47 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Sudeep Holla" <sudeep.holla@....com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Rob Herring" <robh+dt@...nel.org>,
        "Frank Rowand" <frowand.list@...il.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Yang Yang" <yang.yang29@....com>,
        "Geert Uytterhoeven" <geert+renesas@...der.be>,
        "Sebastian Reichel" <sre@...nel.org>,
        "Miquel Raynal" <miquel.raynal@...tlin.com>,
        "Dmitry Baryshkov" <dmitry.baryshkov@...aro.org>,
        "Viresh Kumar" <viresh.kumar@...aro.org>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: rexport of_find_next_cache_node()

On Wed, Oct 11, 2023, at 15:59, Sudeep Holla wrote:
> On Wed, Oct 11, 2023 at 03:14:08PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> This function is now called from a cpufreq driver, but that breaks the
>> build when the caller is in a loadable module, because of a missing
>> export:
>> 
>> ERROR: modpost: "of_find_next_cache_node" [drivers/cpufreq/qcom-cpufreq-nvmem.ko] undefined!
>> 
>> Export this as a GPL-only symbol, like the other related functions in
>> this file.
>> 
>> Fixes: 7683a63c08ff5 ("cpufreq: qcom-nvmem: create L2 cache device")
>> Fixes: a3e31b4588443 ("of: Move definition of of_find_next_cache_node into common code.")
>
> I am bit confused as I see commit a3e31b4588443 didn't drop the export.
> So how is this change fixing that commit ?

My mistake, I was looking for the commit that initially introduced
the function, but didn't notice that this just moved it from powerpc.

I could have used "Fixes: e523f723d69cd ("powerpc: Add
of_find_next_cache_node()")", but it's probably best to just
leave that line out entirely.

    Arnd