linux-kernel - Re: [v2 1/3] drm/panel: ili9882t: Break out as separate driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WFkRqkp8wcGG5uxE+7RqAQ40rSU-12Zig1R--ykcO8ZA@mail.gmail.com>
Date:   Wed, 11 Oct 2023 07:35:53 -0700
From:   Doug Anderson <dianders@...gle.com>
To:     cong yang <yangcong5@...qin.corp-partner.google.com>
Cc:     sam@...nborg.org, neil.armstrong@...aro.org, daniel@...ll.ch,
        hsinyi@...gle.com, linus.walleij@...aro.org, swboyd@...omium.org,
        airlied@...il.com, catalin.marinas@....com, will@...nel.org,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v2 1/3] drm/panel: ili9882t: Break out as separate driver

Hi,

On Tue, Oct 10, 2023 at 10:42 PM cong yang
<yangcong5@...qin.corp-partner.google.com> wrote:
>
> Hi,
>
> On Wed, Oct 11, 2023 at 3:11 AM Doug Anderson <dianders@...gle.com> wrote:
> >
> > Hi,
> >
> > On Tue, Oct 10, 2023 at 5:14 AM Cong Yang
> > <yangcong5@...qin.corp-partner.google.com> wrote:
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
> > > new file mode 100644
> > > index 000000000000..e095ad91c4bc
> > > --- /dev/null
> > > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
> > > @@ -0,0 +1,762 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Panels based on the Ilitek ILI9882T display controller.
> > > + */
> > > +#include <linux/delay.h>
> > > +#include <linux/gpio/consumer.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of.h>
> > > +#include <linux/of_device.h>
> >
> > nit: remove include of linux/of_device.h since you don't use any of
> > the functions declared there.
>
> It seems that of_device_get_match_data will be used.

Right... ...and of_device_get_match_data() is declared in...
<linux/of.h>. :-) See commit 82174a0a9c5c ("of: Move
of_device_get_match_data() declaration") and commit 722d4f06e560
("drm: Explicitly include correct DT includes").

We'll probably need to handle that when picking to downstream, but for
upstream you shouldn't be re-introducing of_device.h.


-Doug