linux-kernel - Re: [PATCH v2] tee: optee: Fix supplicant based device enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9515560-32bc-4f3b-a36c-87f7242081a9@siemens.com>
Date:   Wed, 11 Oct 2023 16:45:29 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Sumit Garg <sumit.garg@...aro.org>,
        op-tee@...ts.trustedfirmware.org
Cc:     jens.wiklander@...aro.org, arnd@...aro.org, ardb@...nel.org,
        jerome.forissier@...aro.org, ilias.apalodimas@...aro.org,
        masahisa.kojima@...aro.org, maxim.uvarov@...aro.org,
        jarkko.sakkinen@...ux.intel.com, linux-kernel@...r.kernel.org,
        "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@...mens.com>
Subject: Re: [PATCH v2] tee: optee: Fix supplicant based device enumeration

On 29.08.23 13:03, Sumit Garg wrote:
> Hi Jan,
> 
> On Fri, 28 Jul 2023 at 19:18, Sumit Garg <sumit.garg@...aro.org> wrote:
>>
>> Currently supplicant dependent optee device enumeration only registers
>> devices whenever tee-supplicant is invoked for the first time. But it
>> forgets to remove devices when tee-supplicant daemon stops running and
>> closes its context gracefully. This leads to following error for fTPM
>> driver during reboot/shutdown:
>>
>> [   73.466791] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff3024
>>
>> Fix this by separating supplicant dependent devices so that the
>> user-space service can detach supplicant devices before closing the
>> supplicant. While at it use the global system workqueue for OP-TEE bus
>> scanning work rather than our own custom one.
>>
>> Reported-by: Jan Kiszka <jan.kiszka@...mens.com>
>> Link: https://github.com/OP-TEE/optee_os/issues/6094
> 
> I see you have marked this issue as resolved. It would be good to have
> your tested-by tag if it works for you.
> 

Sorry for this very late reply. We finally validated that this works
fine for us, though only over 6.1, our current test target. I hope we
can enable tip of tree soon as well. But I think I can still add my

Tested-by: Jan Kiszka <jan.kiszka@...mens.com>

Jan

-- 
Siemens AG, Technology
Linux Expert Center