linux-kernel - Re: [PATCH 2/2] drivers: watchdog: marvell_gti: Program the max_hw_heartbeat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2023 07:51:32 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Bharat Bhushan <bbhushan2@...vell.com>
Cc:     wim@...ux-watchdog.org, inux@...ck-us.net,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        George Cherian <george.cherian@...vell.com>
Subject: Re: [PATCH 2/2] drivers: watchdog: marvell_gti: Program the
 max_hw_heartbeat_ms

On Mon, Oct 09, 2023 at 10:10:37AM +0530, Bharat Bhushan wrote:
> From: George Cherian <george.cherian@...vell.com>
> 
> Program the max_hw_heartbeat_ms value so that the watchdog_pretimeout
> worker is activated. This kernel worker thread makes sure to ping the
> watchdog in case the userspace is unable to do so. This kernel worker
> ping will be done only till the full watchdog timeout there by
> maintaining the watchdog functionality in case of a real hang.
> 
> Signed-off-by: George Cherian <george.cherian@...vell.com>
> Signed-off-by: Bharat Bhushan <bbhushan2@...vell.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/marvell_gti_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_gti_wdt.c
> index 25b7ce0f0738..bfe0c819248c 100644
> --- a/drivers/watchdog/marvell_gti_wdt.c
> +++ b/drivers/watchdog/marvell_gti_wdt.c
> @@ -299,6 +299,7 @@ static int gti_wdt_probe(struct platform_device *pdev)
>  
>  	/* Maximum timeout is 3 times the pretimeout */
>  	wdog_dev->max_timeout = max_pretimeout * 3;
> +	wdog_dev->max_hw_heartbeat_ms = max_pretimeout * 1000;
>  	/* Minimum first timeout (pretimeout) is 1, so min_timeout as 3 */
>  	wdog_dev->min_timeout = 3;
>  	wdog_dev->timeout = wdog_dev->pretimeout;
> -- 
> 2.34.1
>