linux-kernel - Re: [RESEND] kernel/reboot: document function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7debd36-a934-42b6-834d-d21f4a0d8f7d@infradead.org>
Date:   Wed, 11 Oct 2023 08:13:41 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Matti Vaittinen <mazziesaccount@...il.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND] kernel/reboot: document function parameter



On 10/11/23 04:08, Matti Vaittinen wrote:
> The hw_failure_emergency_poweroff() has been documented using kernel
> doc. The documentation omits description of the function parameter
> 'int poweroff_delay_ms' - which seems like self-explatonary.
> 
> However, the build bot is nagging about the missing parameter
> documentation, so add the trivial documentation to shut the bot up.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309040349.HLOK1O5I-lkp@intel.com/
> Fixes: dfa19b11385d ("reboot: Add hardware protection power-off")

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  kernel/reboot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index 3bba88c7ffc6..c7790711242d 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -940,6 +940,7 @@ static DECLARE_DELAYED_WORK(hw_failure_emergency_poweroff_work,
>  
>  /**
>   * hw_failure_emergency_poweroff - Trigger an emergency system poweroff
> + * @poweroff_delay_ms: Time after which the system is rebooted. In milliseconds.
>   *
>   * This may be called from any critical situation to trigger a system shutdown
>   * after a given period of time. If time is negative this is not scheduled.
> 
> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d

-- 
~Randy