linux-kernel - Re: [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSbVhao44Gjftxyh@smile.fi.intel.com>
Date:   Wed, 11 Oct 2023 20:04:05 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace
 in helpers

On Wed, Oct 11, 2023 at 02:07:28PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> We have a set of pinctrl helpers for GPIOLIB drivers that take a number
> from the global GPIO numberspace as argument. We are trying to get rid
> of this global numbering. Let's rework these helpers to use the
> recommended gpio_chip + controller-relative offset instead.
> 
> This work is split into phases: first let's introduce the new variants
> of the helpers. Next: let's convert all users one-by-one for easier
> review. After that let's remove the old helpers and rename the new
> variants to take the place of the old ones. Finally convert static
> functions in pinctrl/core.c to using the same signature and to top it
> off, let's remove now redundant wrappers around the pinctrl_helpers.
> 
> This series introduces no functional changes in drivers so I decided to
> not spam every single driver maintainer anymore.

...

>   pinctrl: intel: use new pinctrl GPIO helpers

If it's going to be a separate patch at the end, please split it even more, so
we will have a lean history for each driver.

...

>   pinctrl: change the signature of pinctrl_gpio_direction()
>   pinctrl: change the signature of pinctrl_get_device_gpio_range()
>   pinctrl: change the signature of pinctrl_match_gpio_range()
>   pinctrl: change the signature of gpio_to_pin()
>   pinctrl: change the signature of pinctrl_ready_for_gpio_range()

For the above
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

...

>   pinctrl: intel: drop the wrappers around pinctrl_gpio_direction_input()

I believe this one can always be done on the driver basis, please split it
to three.

-- 
With Best Regards,
Andy Shevchenko