linux-kernel - Re: [PATCH v2 2/7] serial: amba-pl011: get rid of useless wrapper pl011_get_rs485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2023 19:44:51 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Lino Sanfilippo <l.sanfilippo@...bus.com>
Cc:     jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        cniedermaier@...electronics.com, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, lukas@...ner.de,
        p.rosenberger@...bus.com
Subject: Re: [PATCH v2 2/7] serial: amba-pl011: get rid of useless wrapper
 pl011_get_rs485_mode()


Hi,

On 11.10.23 at 19:42, Greg KH wrote:
> On Wed, Oct 11, 2023 at 07:38:24PM +0200, Lino Sanfilippo wrote:
>> Due to earlier code changes function pl011_get_rs485_mode() is now merely
>> a wrapper for uart_get_rs485_mode() which does not add any further
>> functionality. So remove it and instead call uart_get_rs485_mode()
>> directly.
>>
>> Reviewed-by: Lukas Wunner <lukas@...ner.de>
>> Signed-off-by: Lino Sanfilippo <l.sanfilippo@...bus.com>
>> ---
>>  drivers/tty/serial/amba-pl011.c | 14 +-------------
>>  1 file changed, 1 insertion(+), 13 deletions(-)
>
> Why is patch 2/7 not cc: stable, when patches 3-7 are?  Either this
> patch isn't needed in this series, and can go later (or to a different
> branch), or it also needs to be marked for stable as the later patches
> depend on it?
>

2/7 is really only a cleanup patch that does not provide a bugfix.
Should I remove it from this series?

Regards,
Lino