linux-kernel - Re: [PATCH v2 2/5] mm: kmem: add direct objcg pointer to task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSbj_SGkVj8wMY40@P9FQF9L96D.corp.robot.car>
Date:   Wed, 11 Oct 2023 11:05:49 -0700
From:   Roman Gushchin <roman.gushchin@...ux.dev>
To:     Shakeel Butt <shakeelb@...gle.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        cgroups@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Muchun Song <muchun.song@...ux.dev>,
        Dennis Zhou <dennis@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Rientjes <rientjes@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Subject: Re: [PATCH v2 2/5] mm: kmem: add direct objcg pointer to task_struct

On Wed, Oct 11, 2023 at 06:01:01PM +0000, Shakeel Butt wrote:
> On Mon, Oct 09, 2023 at 05:09:26PM -0700, Roman Gushchin wrote:
> [...]
> > +static void mem_cgroup_kmem_attach(struct cgroup_taskset *tset)
> > +{
> > +	struct task_struct *task;
> > +	struct cgroup_subsys_state *css;
> > +
> > +	cgroup_taskset_for_each(task, css, tset) {
> > +		/* atomically set the update bit */
> > +		set_bit(0, (unsigned long *)&current->objcg);
> 
> task instead of current ??

Oh, right, of course, good catch!

Thanks!