linux-kernel - Re: [PATCH v5] arch/x86: port I/O tracing on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023101129-dragonish-chaplain-ab30@gregkh>
Date:   Wed, 11 Oct 2023 22:41:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dan Raymond <raymod2@...il.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-serial <linux-serial@...r.kernel.org>, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        hpa@...or.com, peterz@...radead.org,
        andriy.shevchenko@...ux.intel.com, quic_saipraka@...cinc.com,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v5] arch/x86: port I/O tracing on x86

On Wed, Oct 11, 2023 at 02:22:14PM -0600, Dan Raymond wrote:
> On 10/7/2023 11:56 AM, Dan Raymond wrote:
> > Add support for port I/O tracing on x86.  Memory mapped I/O tracing is
> > available on x86 via CONFIG_MMIOTRACE but that relies on page faults
> > so it doesn't work with port I/O.  This feature uses tracepoints in a
> > similar manner as CONFIG_TRACE_MMIO_ACCESS.
> > 
> > Signed-off-by: Dan Raymond <raymod2@...il.com>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> > V1 -> V2:
> >   - create header file for prototypes to silence new compiler warning
> >   - reduce CPU overhead to 2 instructions (no branching) when tracing disabled
> >   - fix imprecise IP logging by retrieving the IP off the stack instead of using
> >     compile time labels
> > 
> > V2 -> V3:
> >   - restore missing semicolon
> > 
> > V3 -> V4:
> >   - make GPL licenses consistent
> >   - change pointer arguments from (long) to (void *)
> >   - eliminate include guard checks and use -DDISABLE_TRACEPOINTS instead to
> >     disable tracepoints in arch/x86/boot/*
> >   - fix compiler warnings due to signed/unsigned mismatch in arch_cmpxchg64()
> > 
> > V4 -> V5:
> >   - add -DDISABLE_TRACEPOINTS to arch/x86/realmode/rm/Makefile
> 
> Can I get reviews on this please?

You sent it 3 days ago, please be patient, there is no need to demand
work from others so quickly, most of us are totally swamped.  If after 2
weeks or so with no review, then you can ask again.

In the meantime, to help us out, please do some patch review yourself on
the various mailing lists (the tty list can always use help.)  To ask
for work from others without helping out is not always good...

thanks,

greg k-h