linux-kernel - Re: [PATCH v4] execve.2: execve also returns E2BIG if a string is too long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2023 01:45:15 +0200
From:   Alejandro Colomar <alx@...nel.org>
To:     Rik van Riel <riel@...riel.com>
Cc:     linux-man@...r.kernel.org, kernel-team@...a.com,
        linux-kernel@...r.kernel.org,
        Matthew House <mattlloydhouse@...il.com>,
        Eric Biederman <ebiederm@...ssion.com>
Subject: Re: [PATCH v4] execve.2: execve also returns E2BIG if a string is
 too long

On Wed, Oct 11, 2023 at 04:53:20PM -0400, Rik van Riel wrote:
> On Wed, 2023-10-11 at 22:14 +0200, Alejandro Colomar wrote:
> > Hi Rik,
> > 
> > On Wed, Oct 11, 2023 at 12:53:30PM -0400, Rik van Riel wrote:
> > > Sigh, once again I did a git commit --amend without the latest file
> > > change being
> > > included. The change below should be good. Working with both git
> > > and hg gets me sometimes :/
> > > ---8<---
> > > 
> > > The execve syscall returns -E2BIG in 3 cases:
> > > - The total length of the command line arguments and environment is
> > > too large.
> > > - An argument or environment string is longer than MAX_ARG_STRLEN.
> > 
> > I'm still concerned by the wording of this sentence (and the next
> > one).
> > When I (and any user-space programmer, I think) read "string is
> > longer
> > than FOO", I read `strlen(string) > FOO`.  Since it's rather
> > `strlen(string) >= FOO`, I think you should clarify.  How about this?
> > 
> > -  An argument or environment string is longer (including the null
> > byte)
> >    than MAX_ARG_STRLEN.
> 
> That works. Would you like me to re-send a v5, or do you
> want to massage the changelog when you apply the patch?
> 
> I must admit I paid more attention to the wording in the
> man page than the wording in the changelog :)

I wouldn't mind doing it myself, but I'll ask you to resend, if you
don't mind.  I usually find that doing so helps catch other accidents
that I didn't catch.  :)

Cheers,
Alex

> 
> -- 
> All Rights Reversed.

:)

-- 
<https://www.alejandro-colomar.es/>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)