linux-kernel - Re: [PATCH] mm/list_lru: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231011062545.GA2866435@google.com>
Date:   Wed, 11 Oct 2023 15:25:45 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] mm/list_lru: Remove unused function

On (23/09/22 18:07), Jiapeng Chong wrote:
> The function are defined in the list_lru.c file, but not called
> elsewhere, so delete the unused function.
> 
> mm/list_lru.c:64:1: warning: unused function 'list_lru_from_kmem'.

It seems that this breaks linux-next bisectability:

---

mm/list_lru.c:98:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                l = list_lru_from_kmem(lru, nid, item, &memcg);
                    ^
mm/list_lru.c:98:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion]
                l = list_lru_from_kmem(lru, nid, item, &memcg);
                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/list_lru.c:121:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                l = list_lru_from_kmem(lru, nid, item, NULL);
                    ^
mm/list_lru.c:121:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion]
                l = list_lru_from_kmem(lru, nid, item, NULL);
                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 2 errors generated.