[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231011092350.18049672@kmaincent-XPS-13-7390>
Date: Wed, 11 Oct 2023 09:23:50 +0200
From: Köry Maincent <kory.maincent@...tlin.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Cai Huoqing <cai.huoqing@...ux.dev>,
Serge Semin <fancer.lancer@...il.com>,
Vinod Koul <vkoul@...nel.org>,
Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>,
dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Herve Codina <herve.codina@...tlin.com>
Subject: Re: [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes
On Tue, 10 Oct 2023 20:29:06 +0530
Manivannan Sadhasivam <mani@...nel.org> wrote:
> On Mon, Oct 02, 2023 at 03:17:46PM +0200, Köry Maincent wrote:
> > From: Kory Maincent <kory.maincent@...tlin.com>
> >
> > Fix "HDMA_V0_REMOTEL_STOP_INT_EN" typo error.
> > Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
> > bit is already set in the same line.
> >
>
> You should split this into two patches. First one is a typo and is harmless,
> but the second is a _bug_.
Thanks for your review.
Ok I will do so.
Serge if it is ok for you I will keep your reviewed by on the two separate
patches.
Powered by blists - more mailing lists