linux-kernel - Re: [PATCH] ARM: OMAP1: ams-delta: Fix MODEM initialization failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231011072903.GA34982@atomide.com>
Date:   Wed, 11 Oct 2023 10:29:03 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Janusz Krzysztofik <jmkrzyszt@...il.com>
Cc:     Aaro Koskinen <aaro.koskinen@....fi>,
        Douglas Anderson <dianders@...omium.org>,
        Mark Brown <broonie@...nel.org>, linux-omap@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix MODEM initialization failure

Hi,

* Janusz Krzysztofik <jmkrzyszt@...il.com> [231008 00:47]:
> [    6.823917][    T1] serial8250 serial8250.1: incomplete constraints, dummy supplies not allowed
> [    6.874117][    T1] ------------[ cut here ]------------
> [    6.893918][    T1] WARNING: CPU: 0 PID: 1 at drivers/base/core.c:2486 device_release+0x98/0xa8
> [    6.930626][    T1] Device 'serial8250.1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.

The patch looks OK to me, but can you please trim down the warning for
prettier git log output? At least the timestamps can go, and since
you fixed it, you could trim the message down to something like this:

serial8250 serial8250.1: incomplete constraints, dummy supplies not allowed
WARNING: CPU: 0 PID: 1 at drivers/base/core.c:2486 device_release+0x98/0xa8
Device 'serial8250.1' does not have a release() function, it is broken and
must be fixed. See Documentation/core-api/kobject.rst.
...
put_device from platform_device_put+0x1c/0x24
platform_device_put from ams_delta_init_late+0x4c/0x68
ams_delta_init_late from init_machine_late+0x1c/0x94
init_machine_late from do_one_initcall+0x60/0x1d4

This still allows folks seeing similar errors to find them when searching.
Also the ASoC warnings can be trimmed down a bit, formatting up to you
how you prefer them naturally :)

Thanks,

Tony