linux-kernel - Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231011103306.08f1fbd4@xps-13>
Date:   Wed, 11 Oct 2023 10:33:06 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Walle <michael@...le.cc>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Robert Marko <robert.marko@...tura.hr>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Randy Dunlap <rdunlap@...radead.org>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs

Hi Srinivas,

srinivas.kandagatla@...aro.org wrote on Wed, 11 Oct 2023 09:27:20 +0100:

> On 11/10/2023 08:15, Miquel Raynal wrote:
> >>> +
> >>> +	nvmem_cells_group.bin_attrs = cells_attrs;
> >>> +
> >>> +	ret = devm_device_add_groups(&nvmem->dev, nvmem_cells_groups);
> >>> +	if (ret)
> >>> +		goto unlock_mutex;  
> >> This is going to create groups after the nvmem device is added, isn't this going to be problem with user space notifications?  
> > Greg said it was not. I hope I understood correctly 😄
> > 
> > And anyway, cells have never been available to userspace, so there is
> > nothing userspace might expect yet?  
> I agree, but once we add sysfs uapi then this is going to change.

Can you elaborate? I'm not sure I follow you here. Is there still a
problem you fear or you think it's okay?

Thanks,
Miquèl