linux-kernel - Re: [PATCH v3] usb: typec: ucsi: Use GET_CAPABILITY attributes data to set power supply scope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2023 11:25:17 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     wsa@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Alexander.Deucher@....com,
        Richard.Gong@....com, kai.heng.feng@...onical.com,
        sebastian.reichel@...labora.com,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v3] usb: typec: ucsi: Use GET_CAPABILITY attributes data
 to set power supply scope

On Tue, Oct 10, 2023 at 12:49:35PM -0500, Mario Limonciello wrote:
> On 10/10/2023 03:42, Heikki Krogerus wrote:
> > On Mon, Oct 09, 2023 at 01:46:43PM -0500, Mario Limonciello wrote:
> > > On some OEM systems, adding a W7900 dGPU triggers RAS errors and hangs
> > > at a black screen on startup.  This issue occurs only if `ucsi_acpi` has
> > > loaded before `amdgpu` has loaded.  The reason for this failure is that
> > > `amdgpu` uses power_supply_is_system_supplied() to determine if running
> > > on AC or DC power at startup. If this value is reported incorrectly the
> > > dGPU will also be programmed incorrectly and trigger errors.
> > > 
> > > power_supply_is_system_supplied() reports the wrong value because UCSI
> > > power supplies provided as part of the system don't properly report the
> > > scope as "DEVICE" scope (not powering the system).
> > > 
> > > In order to fix this issue check the capabilities reported from the UCSI
> > > power supply to ensure that it supports charging a battery and that it can
> > > be powered by AC.  Mark the scope accordingly.
> > > 
> > > Cc: stable@...r.kernel.org
> > > Fixes: a7fbfd44c020 ("usb: typec: ucsi: Mark dGPUs as DEVICE scope")
> > > Link: https://www.intel.com/content/www/us/en/products/docs/io/universal-serial-bus/usb-type-c-ucsi-spec.html p28
> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> > 
> > Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 
> Thanks!
> 
> Greg, this behavior is pretty awful with the hang at bootup on these OEM
> systems, do you think this can come into one of the 6.6-rcX or should it
> wait until 6.7?

I'll queue it up for 6.6-final, thanks.

greg k-h