linux-kernel - Re: Sony IMX290/462 image sensors I2C xfer peculiarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3jzrttrmz.fsf@t19.piap.pl>
Date:   Wed, 11 Oct 2023 11:50:12 +0200
From:   Krzysztof Hałasa <khalasa@...p.pl>
To:     linux-media <linux-media@...r.kernel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-i2c@...r.kernel.org,
        Stefan Lengfeld <contact@...fanchrist.eu>
Subject: Re: Sony IMX290/462 image sensors I2C xfer peculiarity

Hi,

adding more people to Cc: as this is more general stuff than my specific
image sensor setup.

Is there any reason for the following (meta) patch to not be applied?

Currently, every i.MX8MP atomic I2C transfer starts with 100 us delay
(just after the START condition). At 400 kHz bus (384 kHz or whatever),
this is equivalent to several tens of bits. Is this delay needed?

This is on NXP 5.15 branch, but it seems the mainline is identical here.

With this patch, the 1-byte (quasi) atomic image sensor register reads
(16-bit address + 8-bit value) are down to ca. 160 us, and writes take
120 us.

It seems one bit on the bus takes ca. 2.66 us (hardware), and the delay
between consecutive bytes is ca. 4.82 us (I guess CPU takes a fair share
of this). This is i.MX8MP @ apparently 1200 MHz (1600 MHz with freq
scaler).

Fire away.
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -534,xx +534,xx @@
 static int i2c_imx_bus_busy(struct imx_i2c_struct *i2c_imx, int for_busy, bool atomic)
 {
     unsigned long orig_jiffies = jiffies;
     unsigned int temp;

     while (1) {
         temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR);

         /* check for arbitration lost */
         if (temp & I2SR_IAL) {
             i2c_imx_clear_irq(i2c_imx, I2SR_IAL);
             return -EAGAIN;
         }

         if (for_busy && (temp & I2SR_IBB)) {
             i2c_imx->stopped = 0;
             break;
         }
         if (!for_busy && !(temp & I2SR_IBB)) {
             i2c_imx->stopped = 1;
             break;
         }
         if (time_after(jiffies, orig_jiffies + msecs_to_jiffies(500))) {
             dev_dbg(&i2c_imx->adapter.dev,
                 "<%s> I2C bus is busy\n", __func__);
             return -ETIMEDOUT;
         }
         if (atomic)
-            udelay(100);
+            udelay(1);
         else
             schedule();
     }

     return 0;
 }
-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa