linux-kernel - Re: [PATCH v3 3/6] soc/tegra: fuse: Add function to add lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231011093735.8069-1-kkartik@nvidia.com>
Date:   Wed, 11 Oct 2023 15:07:35 +0530
From:   Kartik <kkartik@...dia.com>
To:     <andriy.shevchenko@...ux.intel.com>
CC:     <arnd@...db.de>, <digetx@...il.com>, <frank.li@...o.com>,
        <jonathanh@...dia.com>, <kkartik@...dia.com>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <pdeschrijver@...dia.com>, <petlozup@...dia.com>,
        <pshete@...dia.com>, <robh@...nel.org>, <stefank@...dia.com>,
        <sumitg@...dia.com>, <thierry.reding@...il.com>, <windhl@....com>
Subject: Re: [PATCH v3 3/6] soc/tegra: fuse: Add function to add lookups

On Thu, 2023-09-07 at 14:35, Andy Shevchenko wrote:
>On Thu, Sep 07, 2023 at 12:40:49PM +0530, Kartik wrote:
>> Add helper function tegra_fuse_add_lookups() to register Tegra fuse
>> nvmem lookups. So, this can be shared between tegra_fuse_init() and
>> ACPI probe, which is to be introduced later.
>
>...
>
>> +static int tegra_fuse_add_lookups(struct tegra_fuse *fuse)
>> +{
>> +	size_t size;
>> +
>> +	if (!fuse->soc->lookups)
>> +		return 0;
>
>> +	size = size_mul(sizeof(*fuse->lookups), fuse->soc->num_lookups);
>> +
>> +	fuse->lookups = kmemdup(fuse->soc->lookups, size, GFP_KERNEL);
>> +	if (!fuse->lookups)
>> +		return -ENOMEM;
>
>Why not introducing kmemdup_array()?

Introduced this in v4.

>
>> +	nvmem_add_cell_lookups(fuse->lookups, fuse->soc->num_lookups);
>> +
>> +	return 0;
>> +}
>
>...
>
>> +	err = tegra_fuse_add_lookups(fuse);
>> +	if (err) {
>> +		pr_err("failed to add FUSE lookups\n");
>
>Why pr_err() and not dev_err()?

This is called before tegra_fuse_probe in device-tree boot hence the
reason behing using pr_err instead of dev_err.

>
>> +		return err;
>>  	}
>>  
>>  	return 0;
>
>These four lines can be just shortened to
>
>	return err;
>

Updated this in v4.

>-- 
>With Best Regards,
>Andy Shevchenko

Regards,
Kartik