linux-kernel - Re: [PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to client devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y1g7zxnw.fsf@intel.com>
Date:   Thu, 12 Oct 2023 18:08:03 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Jean Delvare <jdelvare@...e.com>,
        "lakshmiy@...ibm.com" <lakshmiy@...ibm.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "joel@....id.au" <joel@....id.au>,
        "christian.koenig@....com" <christian.koenig@....com>,
        "andrew@...id.au" <andrew@...id.au>,
        "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
        "ninad@...ux.ibm.com" <ninad@...ux.ibm.com>,
        "eajames@...ux.ibm.com" <eajames@...ux.ibm.com>,
        "wsa@...nel.org" <wsa@...nel.org>
Cc:     "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to
 client devices

On Thu, 12 Oct 2023, Jean Delvare <jdelvare@...e.com> wrote:
> On Mon, 2023-10-09 at 16:14 -0500, Lakshmi Yadlapati wrote:
>> Signed-off-by: Lakshmi Yadlapati <lakshmiy@...ibm.com>
>> ---
>>  drivers/i2c/i2c-core-base.c  |   8 +-
>>  drivers/i2c/i2c-core-smbus.c | 143 ++++++++++++++++++++++++++++-------
>>  drivers/i2c/i2c-core.h       |  23 ++++++
>>  include/linux/i2c.h          |   2 +
>>  4 files changed, 145 insertions(+), 31 deletions(-)
>> (...)
>
> Non-trivial patch with no description -> not even looking, sorry. You
> can't possibly propose a change to the core of a subsystem and not
> bother explaining why this change is needed or what purpose it serves.

We've even managed to write extensive documentation on this!

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

>
> (And yes I know there's some information in patch 0/2, but that's not
> going to make it into git, so it will be lost. Commits should be self-
> sufficient, not only the implementation, but also the description.)
>
> I would also suggest trimming the To and Cc lists. I can't really see
> how linux-media and dri-devel are relevant here for example.

-- 
Jani Nikula, Intel