linux-kernel - Re: [PATCH] lib: zstd: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B6F7FAB1-3A03-4F7D-8957-ED93600AD0DE@meta.com>
Date:   Thu, 12 Oct 2023 15:57:39 +0000
From:   Nick Terrell <terrelln@...a.com>
To:     "baomingtong001@...suo.com" <baomingtong001@...suo.com>
CC:     Nick Terrell <terrelln@...a.com>, Nick Terrell <terrelln@...a.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib: zstd: remove unneeded variable



> On Jun 14, 2023, at 3:14 AM, baomingtong001@...suo.com wrote:
> 
> !-------------------------------------------------------------------|
> This Message Is From an Untrusted Sender
> You have not previously corresponded with this sender.
> |-------------------------------------------------------------------!
> 
> fix the following coccicheck warning:
> 
> lib/zstd/compress/zstd_cwksp.h:220:17-27: Unneeded variable: "slackSpace". Return "ZSTD_CWKSP_ALIGNMENT_BYTES".

If you would like to fix this, please fix this upstream at https://github.com/facebook/zstd.
That will get synced to the kernel on the next update.

Thanks,
Nick Terrell

> Signed-off-by: Mingtong Bao <baomingtong001@...suo.com>
> ---
> lib/zstd/compress/zstd_cwksp.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/zstd/compress/zstd_cwksp.h b/lib/zstd/compress/zstd_cwksp.h
> index 349fc923c355..36c574cd3d6f 100644
> --- a/lib/zstd/compress/zstd_cwksp.h
> +++ b/lib/zstd/compress/zstd_cwksp.h
> @@ -217,8 +217,7 @@ MEM_STATIC size_t ZSTD_cwksp_slack_space_required(void) {
>      * n_1 + n_2 == 64 bytes if the cwksp is freshly allocated, due to tables and
>      * aligneds being sized in multiples of 64 bytes.
>      */
> -    size_t const slackSpace = ZSTD_CWKSP_ALIGNMENT_BYTES;
> -    return slackSpace;
> +    return ZSTD_CWKSP_ALIGNMENT_BYTES;
> }


Download attachment "winmail.dat" of type "application/ms-tnef" (13468 bytes)