linux-kernel - Re: [PATCH] lib: zstd: Clean up errors in zstd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E9A0875B-52BB-4B18-A48A-3611915B6C6B@meta.com>
Date:   Thu, 12 Oct 2023 16:18:27 +0000
From:   Nick Terrell <terrelln@...a.com>
To:     KaiLong Wang <wangkailong@...i.cn>
CC:     Nick Terrell <terrelln@...a.com>, Nick Terrell <terrelln@...a.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib: zstd: Clean up errors in zstd_ddict.h



> On Sep 27, 2023, at 11:23 PM, KaiLong Wang <wangkailong@...i.cn> wrote:
> 
> > 
> Fix the following errors reported by checkpatch:
> 
> ERROR: "foo* bar" should be "foo *bar"

The zstd library is synced from upstream and does not fully conform to the Linux Kernel style guide.

Though if you notice errors in include/linux/zstd.h, our public API, please let me know.

Thanks,
Nick Terrell

> Signed-off-by: KaiLong Wang <wangkailong@...i.cn>
> ---
> lib/zstd/decompress/zstd_ddict.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/zstd/decompress/zstd_ddict.h b/lib/zstd/decompress/zstd_ddict.h
> index 8c1a79d666f8..8fd15fca3724 100644
> --- a/lib/zstd/decompress/zstd_ddict.h
> +++ b/lib/zstd/decompress/zstd_ddict.h
> @@ -34,10 +34,10 @@
>  * ZSTD_getDictID_fromDict()
>  */
> 
> -const void* ZSTD_DDict_dictContent(const ZSTD_DDict* ddict);
> -size_t ZSTD_DDict_dictSize(const ZSTD_DDict* ddict);
> +const void *ZSTD_DDict_dictContent(const ZSTD_DDict *ddict);
> +size_t ZSTD_DDict_dictSize(const ZSTD_DDict *ddict);
> 
> -void ZSTD_copyDDictParameters(ZSTD_DCtx* dctx, const ZSTD_DDict* ddict);
> +void ZSTD_copyDDictParameters(ZSTD_DCtx *dctx, const ZSTD_DDict *ddict);
> 
> 
> 
> -- 
> 2.17.1


Download attachment "winmail.dat" of type "application/ms-tnef" (13423 bytes)