[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <169712792200.1188719.6103742227495646067.robh@kernel.org>
Date: Thu, 12 Oct 2023 11:25:22 -0500
From: Rob Herring <robh@...nel.org>
To: Eugen Hristev <eugen.hristev@...labora.com>
Cc: angelogioacchino.delregno@...labora.com,
devicetree@...r.kernel.org, kernel@...labora.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
matthias.bgg@...il.com, conor+dt@...nel.org,
linux-kernel@...r.kernel.org, broonie@...nel.org,
alsa-devel@...a-project.org, linux-mediatek@...ts.infradead.org,
lgirdwood@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] dt-bindings: arm: mediatek: convert audsys and
mt2701-afe-pcm to yaml
On Thu, 12 Oct 2023 18:15:38 +0300, Eugen Hristev wrote:
> Convert the mediatek,audsys binding to YAML, together with the associated
> binding bindings/sound/mt2701-afe-pcm.yaml .
>
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> ---
> Changes in v3:
> - not added Rb Conor Dooley since the patch was changed in a big essence
> - As per review by Krzysztof, also convert the mt2701-afe-pcm and reference
> the correct schema in the audsys binding.
>
> Changes in v2:
> - remove comment reference to inexistent binding
>
>
> .../bindings/arm/mediatek/mediatek,audsys.txt | 39 ---
> .../arm/mediatek/mediatek,audsys.yaml | 153 ++++++++++++
> .../bindings/sound/mt2701-afe-pcm.txt | 146 -----------
> .../bindings/sound/mt2701-afe-pcm.yaml | 229 ++++++++++++++++++
> 4 files changed, 382 insertions(+), 185 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.txt
> create mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/mt2701-afe-pcm.yaml:11:4: [error] missing starting space in comment (comments)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231012151538.468893-1-eugen.hristev@collabora.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists