[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fdmytyymltbc2wvsobbbu57vfturwiq755fuj6vt5g35bf77ls@gkscepiyvn5a>
Date: Thu, 12 Oct 2023 09:48:38 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: soc: qcom: qcom,pmic-glink: add a
gpio used to determine the Type-C port plug orientation
On Fri, Oct 06, 2023 at 10:40:35AM -0500, Rob Herring wrote:
> On Mon, Oct 02, 2023 at 12:20:21PM +0200, Neil Armstrong wrote:
> > On SM8450 and SM8550 based platforms, the Type-C plug orientation is given on a
> > GPIO line for each connector which are set by the PMIC(s).
> >
> > Document this optional Type-C connector property, and take the
> > assumption an active level represents an inverted/flipped orientation.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> > ---
> > .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> > index bceb479f74c5..422921cf1f82 100644
> > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> > @@ -35,6 +35,12 @@ properties:
> > '#size-cells':
> > const: 0
> >
> > + orientation-gpios:
> > + description: Array of input gpios for the Type-C connector orientation indication.
> > + The GPIO indication is used to detect the orientation of the Type-C connector.
> > + The array should contain a gpio entry for each PMIC Glink connector, in reg order.
> > + It is defined that GPIO active level means "CC2" or Reversed/Flipped orientation.
>
> Shouldn't this node then have 'orientation-switch'?
The 'orientation-switch' property denotes that the node is the sink of a
orientation switching event, but this node represents the source of such
events (i.e. the connector-side).
The array defines the gpio signal providing the current orientation for
each of the listed usb-c-connectors under the node.
Regards,
Bjorn
Powered by blists - more mailing lists