linux-kernel - Re: [PATCH 1/1] perf build: Add missing comment about NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cjYRbdmEuqob8wC4Ca9DSpg+fCv85jWnuOZQ8grDcJnWQ@mail.gmail.com>
Date:   Thu, 12 Oct 2023 10:21:54 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] perf build: Add missing comment about NO_LIBTRACEEVENT=1

On Thu, Oct 5, 2023 at 8:45 AM Ian Rogers <irogers@...gle.com> wrote:
>
> On Thu, Oct 5, 2023 at 6:46 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> >
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> >
> > By default perf will fail the build if the development files for
> > libtraceevent are not available.
> >
> > To build perf without libtraceevent support, disabling several features
> > such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make
> > command line.
> >
> > Add the missing comments about that to the tools/perf/Makefile.perf
> > file, just like all the other such command line toggles.
> >
> > Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Ian Rogers <irogers@...gle.com>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Applied to perf-tools-next, thanks!