lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231012172623.ut5kxdvfpofi7omk@synopsys.com>
Date:   Thu, 12 Oct 2023 17:26:43 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Krishna Kurapati <quic_kriskura@...cinc.com>
CC:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Felipe Balbi <balbi@...nel.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Johan Hovold <johan@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "quic_pkondeti@...cinc.com" <quic_pkondeti@...cinc.com>,
        "quic_ppratap@...cinc.com" <quic_ppratap@...cinc.com>,
        "quic_jackp@...cinc.com" <quic_jackp@...cinc.com>,
        "ahalaney@...hat.com" <ahalaney@...hat.com>,
        "quic_shazhuss@...cinc.com" <quic_shazhuss@...cinc.com>,
        Harsh Agarwal <quic_harshq@...cinc.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v13 03/10] usb: dwc3: core: Refactor PHY logic to support
 Multiport Controller

Hi,

On Sat, Oct 07, 2023, Krishna Kurapati wrote:
> From: Harsh Agarwal <quic_harshq@...cinc.com>
> 
> Currently the DWC3 driver supports only single port controller
> which requires at most one HS and one SS PHY.
> 
> But the DWC3 USB controller can be connected to multiple ports and
> each port can have their own PHYs. Each port of the multiport
> controller can either be HS+SS capable or HS only capable
> Proper quantification of them is required to modify GUSB2PHYCFG
> and GUSB3PIPECTL registers appropriately.
> 
> Add support for detecting, obtaining and configuring phy's supported
> by a multiport controller and. Limit the max number of ports
> supported to 4 as only SC8280 which is a quad port controller supports
> Multiport currently.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202309200156.CxQ3yaLY-lkp@intel.com/__;!!A4F2R9G_pg!fTcK8QrbE_IGWMo0AY7E6Wi_MSBhyN_Q1jt8aTsB4s0YTY7ltK3pVHyEc4JlBBL3NClZD1vhKmKCWxXabuaXaSQvka5emA$ 
> Co-developed-by: Harsh Agarwal <quic_harshq@...cinc.com>
> Signed-off-by: Harsh Agarwal <quic_harshq@...cinc.com>
> Co-developed-by:Krishna Kurapati <quic_kriskura@...cinc.com>
> Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
> ---
> Changes in v13:
> Compiler issues found by kernel test robot have been fixed and tags added.
> So removing maintainers reviewed-by tag as we have made a minor change
> in the patch.
> 
>  drivers/usb/dwc3/core.c | 252 +++++++++++++++++++++++++++-------------
>  drivers/usb/dwc3/core.h |  11 +-
>  drivers/usb/dwc3/drd.c  |  15 ++-
>  3 files changed, 190 insertions(+), 88 deletions(-)
> 

Please check and address checkpatch issues. You can ignore the ENOSYS
warnings.

WARNING:BAD_SIGN_OFF: Co-developed-by: should not be used to attribute nominal patch author 'Harsh Agarwal <quic_harshq@...cinc.com>'
#41: 
Co-developed-by: Harsh Agarwal <quic_harshq@...cinc.com>

WARNING:BAD_SIGN_OFF: Use a single space after Co-developed-by:
#43: 
Co-developed-by:Krishna Kurapati <quic_kriskura@...cinc.com>

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#368: FILE: drivers/usb/dwc3/core.c:1450:
+			if (ret == -ENOSYS || ret == -ENODEV)

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#384: FILE: drivers/usb/dwc3/core.c:1465:
+			if (ret == -ENOSYS || ret == -ENODEV)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dwc->num_usb2_ports > DWC3_MAX_PORTS'
#432: FILE: drivers/usb/dwc3/core.c:1980:
+	if ((dwc->num_usb2_ports > DWC3_MAX_PORTS) ||
+		(dwc->num_usb3_ports > DWC3_MAX_PORTS))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dwc->num_usb3_ports > DWC3_MAX_PORTS'
#432: FILE: drivers/usb/dwc3/core.c:1980:
+	if ((dwc->num_usb2_ports > DWC3_MAX_PORTS) ||
+		(dwc->num_usb3_ports > DWC3_MAX_PORTS))

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#433: FILE: drivers/usb/dwc3/core.c:1981:
+	if ((dwc->num_usb2_ports > DWC3_MAX_PORTS) ||
+		(dwc->num_usb3_ports > DWC3_MAX_PORTS))

WARNING:TABSTOP: Statements should start on a tabstop
#490: FILE: drivers/usb/dwc3/core.c:2302:
+		 for (i = 0; i < dwc->num_usb2_ports; i++) {

total: 0 errors, 5 warnings, 3 checks, 492 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH v13 03/10] usb: dwc3: core: Refactor PHY logic to support" has style problems, please review.


BR,
Thinh

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ