linux-kernel - Re: [RFC PATCH] ssb: relax SSB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13eeb01a-2f4f-4c8e-b097-6e80d822862b@infradead.org>
Date:   Wed, 11 Oct 2023 20:44:49 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Michael Büsch <m@...s.ch>
Cc:     linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies

Hi Michael,

On 10/10/23 11:43, Michael Büsch wrote:
> On Sun, 8 Oct 2023 23:12:49 -0700
> Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> -	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
>> +	depends on PCI=n || SSB_PCICORE_HOSTMODE
> 
> I thought about something like this:
> 
> depends on (SSB_DRIVER_MIPS && PCI=n) || (SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE)
> 
> Would that solve the warning?

Yes, that works as well, although I prefer to express it like this:

 config SSB_EMBEDDED
 	bool
-	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
+	depends on SSB_DRIVER_MIPS
+	depends on PCI=n || SSB_PCICORE_HOSTMODE
 	default y

although if you prefer the way that you have it above,
I'm OK with that also.

Thanks for your help.

-- 
~Randy