linux-kernel - Re: [PATCH] selftests/nolibc: add tests for multi-object linkage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5f1a910-dbac-44d8-b9f6-5725bea948b2@paulmck-laptop>
Date:   Thu, 12 Oct 2023 12:06:33 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Willy Tarreau <w@....eu>, Zhangjin Wu <falcon@...ylab.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/nolibc: add tests for multi-object linkage

On Thu, Oct 12, 2023 at 08:39:14PM +0200, Thomas Weißschuh wrote:
> On 2023-10-12 11:25:02-0700, Paul E. McKenney wrote:
> > [..]
> 
> > > Please pull the changes since the v6.6-rc1 tag from
> > > https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git/
> > > 
> > > The branch 'fixes' up to and including
> > > 90864f0679fdbb3b2e1c3bdbe4b0a34df785cb0a for the v6.6 cycle.
> > > 
> > > The branch 'next' up to and including
> > > f2c7923763dae51226584494722349fef4df3748 for linux-next.
> > > 
> > > The branch 'next', based upon 'fixes', was tested as follows:
> > > 
> > > i386:          162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > x86_64:        162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > arm64:         162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > arm:           162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > mips:          162 test(s): 161 passed,   1 skipped,   0 failed => status: warning
> > > ppc:           162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > ppc64:         162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > ppc64le:       162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > riscv:         162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > > s390:          162 test(s): 161 passed,   1 skipped,   0 failed => status: warning
> > > loongarch:     162 test(s): 161 passed,   1 skipped,   0 failed => status: warning
> > 
> > I have a signed tag urgent/nolibc.2023.10.12a in the -rcu tree, so
> > please check the lead-in text for sanity.  (Everything after the digital
> > signature is automatically generated.)
> 
> Looks good. But it's only a listing of the commit subjects, correct?

Pretty close, just a few added words on the last one.

So the question is whether there is some larger issue that Linus should
be made aware of.  If these are just simple fixes for simple bugs,
we should be good, but yes, I do need to ask.  ;-)

> > Testing for urgent/nolibc.2023.10.12a:
> > make run: 160 test(s): 160 passed,   0 skipped,   0 failed => status: success
> > make run-user: 160 test(s): 158 passed,   2 skipped,   0 failed => status: warning
> > 
> > Testing for full nolibc stack:
> > make run: 162 test(s): 162 passed,   0 skipped,   0 failed => status: success
> > make run-user: 162 test(s): 160 passed,   2 skipped,   0 failed => status: warning
> > 
> > > > But after about Wednesday of next week, getting things into the upcoming
> > > > merge window is pretty much as fast as sending them quickly to Linus,
> > > > if that makes sense.  Unless there is to be a -rc8 this time, but I
> > > > have heard no sign of that.
> > > > 
> > > > Make sense?
> > > 
> > > Sure, hopefully no more fixes are needed!
> > 
> > Ah, and have these been posted to a public mailing list?  If not, then I
> > need to send them out.
> 
> All patches went through the lists as part of the normal developent
> flow. They were not posted after rebasing.

I have been sending the group, so I might as well continue the tradition.

There are a couple of substantive checkpatch complaints:

4b4a30ea14d1 ("tools/nolibc: i386: Fix a stack misalign bug on _start")
	The Fixes SHA-1 should be limited to 12 hex digits.
	(I am ignoring this, but be prepared for Linus to gripe.
	If you decide to fix it, I would be happy to repull.)

f2c7923763da ("selftests/nolibc: add tests for multi-object linkage")
	nolibc-test-linkage.c and nolibc-test-linkage.h need
	"//" comment for the SPDX comment header.  This one needs
	to be fixed, but this is not in the urgent stack, so there
	is some time.

> For transparency I did the following follow-up changes:
> 
> * The rebase of "tools/nolibc: mark start_c as weak" required some
>   minor changes to resolve conflicts.
> * reword the message of
>   "tools/nolibc: drop test for getauxval(AT_PAGESZ)" slightly.
> * simplify the includes intruduced by
>   "selftests/nolibc: add tests for multi-object linkage".

Sounds good!

							Thanx, Paul

> > We reset the -next testing clock, so if all goes well, then I send the
> > three urgent commits to Linus on Monday.
> 
> Sounds good, thanks!
> 
> Thomas