linux-kernel - Re: [PATCH] rust: error: fix the description for `ECHILD`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72n=y7GtYEEF3042-JLhcpLMAk2ammh2DGkO+1ELXBc=NA@mail.gmail.com>
Date:   Thu, 12 Oct 2023 23:00:09 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Benno Lossin <benno.lossin@...ton.me>
Cc:     Wedson Almeida Filho <wedsonaf@...il.com>,
        rust-for-linux@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Andreas Hindborg <a.hindborg@...sung.com>,
        Alice Ryhl <aliceryhl@...gle.com>,
        linux-kernel@...r.kernel.org,
        Wedson Almeida Filho <walmeida@...rosoft.com>
Subject: Re: [PATCH] rust: error: fix the description for `ECHILD`

On Mon, Oct 9, 2023 at 4:54 PM Benno Lossin <benno.lossin@...ton.me> wrote:
>
> Strictly speaking, `errno-base.h` documents this as "No child
> processes" (note the plural), but I am fine with taking it as-is.

Good catch.

POSIX seems to use both (General Information vs. `<errno.h>`), so
perhaps that is where Wedson picked it from.

Given the kernel uses the plural, and that the commit message says it
mimics `errno-base.h`, I have amended it.

Cheers,
Miguel

1:  77983c791960 ! 1:  17bfcd6a8153 rust: error: fix the description
for `ECHILD`
    @@ Commit message
         Fixes: 266def2a0f5b ("rust: error: add codes from `errno-base.h`")
         Cc: stable@...r.kernel.org
         Link: https://lore.kernel.org/r/20230930144958.46051-1-wedsonaf@gmail.com
    +    [ Use the plural, as noticed by Benno. ]
         Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

      ## rust/kernel/error.rs ##
    @@ rust/kernel/error.rs: macro_rules! declare_err {
          declare_err!(ENOEXEC, "Exec format error.");
          declare_err!(EBADF, "Bad file number.");
     -    declare_err!(ECHILD, "Exec format error.");
    -+    declare_err!(ECHILD, "No child process.");
    ++    declare_err!(ECHILD, "No child processes.");
          declare_err!(EAGAIN, "Try again.");
          declare_err!(ENOMEM, "Out of memory.");
          declare_err!(EACCES, "Permission denied.");