[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231012213428.1390905-1-nickrterrell@gmail.com>
Date: Thu, 12 Oct 2023 14:34:28 -0700
From: Nick Terrell <nickrterrell@...il.com>
To: linux-kernel@...r.kernel.org
Cc: Nick Terrell <terrelln@...a.com>,
Nick Terrell <nickrterrell@...il.com>,
Kernel Team <Kernel-team@...com>,
Nick Terrell <terrelln@...com>,
syzbot+1f2eb3e8cd123ffce499@...kaller.appspotmail.com,
Eric Biggers <ebiggers@...nel.org>,
Kees Cook <keescook@...omium.org>
Subject: [PATCH] zstd: Fix array-index-out-of-bounds UBSAN warning
From: Nick Terrell <terrelln@...com>
Zstd used an array of length 1 to mean a flexible array for C89
compatibility. Switch to a C99 flexible array to fix the UBSAN warning.
Tested locally by booting the kernel and writing to and reading from a
BtrFS filesystem with zstd compression enabled. I was unable to reproduce
the issue before the fix, however it is a trivial change.
Reported-by: syzbot+1f2eb3e8cd123ffce499@...kaller.appspotmail.com
Reported-by: Eric Biggers <ebiggers@...nel.org>
Reported-by: Kees Cook <keescook@...omium.org>
Signed-off-by: Nick Terrell <terrelln@...a.com>
---
lib/zstd/common/fse_decompress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/zstd/common/fse_decompress.c b/lib/zstd/common/fse_decompress.c
index a0d06095be83..8dcb8ca39767 100644
--- a/lib/zstd/common/fse_decompress.c
+++ b/lib/zstd/common/fse_decompress.c
@@ -312,7 +312,7 @@ size_t FSE_decompress_wksp(void* dst, size_t dstCapacity, const void* cSrc, size
typedef struct {
short ncount[FSE_MAX_SYMBOL_VALUE + 1];
- FSE_DTable dtable[1]; /* Dynamically sized */
+ FSE_DTable dtable[]; /* Dynamically sized */
} FSE_DecompressWksp;
--
2.42.0
Powered by blists - more mailing lists