linux-kernel - [PATCH] staging: rts5208: Parenthesize macro arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2023 22:02:40 -0700
From:   Soumya Negi <soumya.negi97@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Micky Ching <micky_ching@...lsil.com.cn>
Cc:     Soumya Negi <soumya.negi97@...il.com>, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rts5208: Parenthesize macro arguments

Use parenthesis with macro arguments to avoid possible precedence
issues. Found by checkpatch.pl

Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
---
 drivers/staging/rts5208/rtsx.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.h b/drivers/staging/rts5208/rtsx.h
index 2e101da83220..1cc05956ab6d 100644
--- a/drivers/staging/rts5208/rtsx.h
+++ b/drivers/staging/rts5208/rtsx.h
@@ -40,17 +40,17 @@
  * macros for easy use
  */
 #define rtsx_writel(chip, reg, value) \
-	iowrite32(value, (chip)->rtsx->remap_addr + reg)
+	iowrite32(value, (chip)->rtsx->remap_addr + (reg))
 #define rtsx_readl(chip, reg) \
-	ioread32((chip)->rtsx->remap_addr + reg)
+	ioread32((chip)->rtsx->remap_addr + (reg))
 #define rtsx_writew(chip, reg, value) \
-	iowrite16(value, (chip)->rtsx->remap_addr + reg)
+	iowrite16(value, (chip)->rtsx->remap_addr + (reg))
 #define rtsx_readw(chip, reg) \
-	ioread16((chip)->rtsx->remap_addr + reg)
+	ioread16((chip)->rtsx->remap_addr + (reg))
 #define rtsx_writeb(chip, reg, value) \
-	iowrite8(value, (chip)->rtsx->remap_addr + reg)
+	iowrite8(value, (chip)->rtsx->remap_addr + (reg))
 #define rtsx_readb(chip, reg) \
-	ioread8((chip)->rtsx->remap_addr + reg)
+	ioread8((chip)->rtsx->remap_addr + (reg))
 
 #define rtsx_read_config_byte(chip, where, val) \
 	pci_read_config_byte((chip)->rtsx->pci, where, val)
@@ -131,8 +131,8 @@ static inline struct rtsx_dev *host_to_rtsx(struct Scsi_Host *host)
  * The scsi_lock() and scsi_unlock() macros protect the sm_state and the
  * single queue element srb for write access
  */
-#define scsi_unlock(host)	spin_unlock_irq(host->host_lock)
-#define scsi_lock(host)		spin_lock_irq(host->host_lock)
+#define scsi_unlock(host)	spin_unlock_irq((host)->host_lock)
+#define scsi_lock(host)		spin_lock_irq((host)->host_lock)
 
 #define lock_state(chip)	spin_lock_irq(&((chip)->rtsx->reg_lock))
 #define unlock_state(chip)	spin_unlock_irq(&((chip)->rtsx->reg_lock))
-- 
2.17.1