linux-kernel - Re: [PATCH] fpga: altera-ps-spi: Use spi_get_device_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2023 13:04:34 +0800
From:   Xu Yilun <yilun.xu@...ux.intel.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: altera-ps-spi: Use spi_get_device_match_data()

On Mon, Oct 09, 2023 at 07:48:07AM -0500, Rob Herring wrote:
> On Sat, Oct 7, 2023 at 2:56 AM Xu Yilun <yilun.xu@...ux.intel.com> wrote:
> >
> > On Sat, Oct 07, 2023 at 03:43:41PM +0800, Xu Yilun wrote:
> > > On Fri, Oct 06, 2023 at 05:46:24PM -0500, Rob Herring wrote:
> > > > Use preferred spi_get_device_match_data() instead of of_match_device() and
> > > > spi_get_device_id() to get the driver match data. With this, adjust the
> > > > includes to explicitly include the correct headers.
> > > >
> > > > Signed-off-by: Rob Herring <robh@...nel.org>
> > >
> > > Acked-by: Xu Yilun <yilun.xu@...el.com>
> > >
> > > Applied.
> > >
> > > >
> > > >  static const struct spi_device_id altera_ps_spi_ids[] = {
> > > > -   { "cyclone-ps-spi", CYCLONE5 },
> > > > -   { "fpga-passive-serial", CYCLONE5 },
> > > > -   { "fpga-arria10-passive-serial", ARRIA10 },
> > > > +   { "cyclone-ps-spi", (uintptr_t)&c5_data },
> > > > +   { "fpga-passive-serial", (uintptr_t)&c5_data },
> > > > +   { "fpga-arria10-passive-serial", (uintptr_t)&a10_data },
> >
> > Sorry, one more. Should cast to kernel_ulong_t?
> 
> Either will work. uintptr_t is somewhat new in the kernel and
> preferred now I think.

LGTM, Applied.

> 
> Rob