linux-kernel - Re: [PATCH v2 3/4] mtd: rawnand: brcmnand: pass host struct to bcmnand_ctrl_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20231012091202.7c963f3f@xps-13>
Date:   Thu, 12 Oct 2023 09:12:02 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     dregan@...l.com
Cc:     bcm-kernel-feedback-list@...adcom.com,
        linux-mtd@...ts.infradead.org, f.fainelli@...il.com,
        rafal@...ecki.pl, joel.peshkin@...adcom.com,
        computersforpeace@...il.com, dan.beygelman@...adcom.com,
        william.zhang@...adcom.com, frieder.schrempf@...tron.de,
        linux-kernel@...r.kernel.org, vigneshr@...com, richard@....at,
        bbrezillon@...nel.org, kdasu.kdev@...il.com,
        JaimeLiao <jaimeliao.tw@...il.com>,
        Arseniy Krasnov <AVKrasnov@...rdevices.ru>,
        Adam Borowski <kilobyte@...band.pl>
Subject: Re: [PATCH v2 3/4] mtd: rawnand: brcmnand: pass host struct to
 bcmnand_ctrl_poll_status

Hi,

dregan@...l.com wrote on Thu, 12 Oct 2023 02:41:48 +0200:

> pass host struct to bcmnand_ctrl_poll_status instead of ctrl struct,

Capital letter

> since real time status requires host, and ctrl is a member of host.

real time status? I'm sorry this commit log is not very clear.

> 
> Signed-off-by: David Regan <dregan@...l.com>
> 

This new line should be dropped (in all your commit logs)

> ---
> 
> Changes in v2: added this patch in series

The versioning is wrong btw, you should continuously increase the
counter, this is not just your second version. And as I said please use
b4 or git-send-email so patches 2+ are answers of patch 1 and in my
inbox it looks like 4 related patches instead.

Thanks,
Miquèl